Skip to content

Add option to disable the extension for defined languages #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
guillaumebriday opened this issue Aug 22, 2018 · 3 comments
Closed
Labels
bug Something isn't working

Comments

@guillaumebriday
Copy link
Contributor

Hey ! First thank you for your extension.

What I mean in the title is for example :

"[markdown]": {
  "tailwind.enabled": false,
},

Because of this :

screen shot 2018-08-23 at 00 21 22

Thank you in advance

@bradlc
Copy link
Contributor

bradlc commented Aug 24, 2018

👋 This is definitely not ideal, and something I want to improve.

I’m not sure an enable/disable option is the right solution though, as you'll still get this issue in file types which you have enabled. I this this issue can be solved by tightening up the conditions under which the suggestions are triggered.

I will work on this later today or tomorrow and let you know

@bradlc bradlc added the bug Something isn't working label Aug 24, 2018
bradlc added a commit that referenced this issue Aug 25, 2018
@bradlc
Copy link
Contributor

bradlc commented Aug 25, 2018

This should be a lot better now, in 0.1.7

It’s a bit smarter, so things like your example ("this is a demo.") won’t trigger the suggestions.

@bradlc bradlc closed this as completed Aug 25, 2018
@guillaumebriday
Copy link
Contributor Author

I'll give it a shot !

Thanks for your work ! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants