Skip to content

Handle postcss throwing when parsing more complex files #1043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

philipp-spiess
Copy link
Member

@philipp-spiess philipp-spiess commented Aug 28, 2024

Fixes: #1033
Fixes: #1034
Fixes: #1035
Fixes: #1036
Fixes: #1037
Fixes: #1038
Fixes: #1039
Fixes: #1040
Fixes: #1041
Fixes: #1042
Fixes: tailwindlabs/tailwindcss#14274

When we worked on #1030, we added a new postcss run inside the project locator. Unfortunately this can crash (e.g. when non standard CSS features are discovered like those in a .sass or .scss file) which currently breaks the whole project locator step, making the extension not work anymore as soon as such a file is detected.

The short term fix here is to handle this error. In the very future we have to replace this postcss step anyways because now that Tailwind v4 supports plugins and JS config files, we need to be able to execute the config to get the proper sources.

Before

before

After

after

@lrungg
Copy link

lrungg commented Aug 28, 2024

for people with that issue: Just switch to the pre-release version of the extension, worked for me.

@philipp-spiess
Copy link
Member Author

@lrungg The fix or this was already released as version 0.12.8 so it should be fine to update to the latest stable version. 🙂

@medz
Copy link

medz commented Aug 28, 2024

Oh my god! I never thought it was a problem with Tailwind SLP! I changed four or five editors because of this problem, and I always thought there was a problem with my project! In the past three days, I removed scss files every day to try to solve this problem! 😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment