Improve support for source(…) feature in v4
#1083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ed3cbaa to
a5daeec
Compare
5f2bc92 to
c1e51e0
Compare
12004bb to
c2f8357
Compare
We were booting the LSP no matter what which broke detection when CSS-files were created
c2f8357 to
6f6d988
Compare
6f6d988 to
3e8d3d4
Compare
Contributor
Author
|
@philipp-spiess @RobinMalfait I still want to do another pass on this for spelling / punctuation / etc… (can still point them out if you see them) but this should otherwise be ready for review. |
packages/tailwindcss-language-server/tests/diagnostics/source-diagnostics.test.js
Outdated
Show resolved
Hide resolved
packages/tailwindcss-language-server/tests/diagnostics/source-diagnostics.test.js
Outdated
Show resolved
Hide resolved
packages/tailwindcss-language-service/src/completions/file-paths.test.ts
Outdated
Show resolved
Hide resolved
packages/tailwindcss-language-service/src/diagnostics/getInvalidTailwindDirectiveDiagnostics.ts
Show resolved
Hide resolved
| } | ||
|
|
||
| if (!anyFolderNeedsLanguageServer(Workspace.workspaceFolders ?? [])) { | ||
| if (!await anyFolderNeedsLanguageServer(Workspace.workspaceFolders ?? [])) { |
Contributor
Author
There was a problem hiding this comment.
I need to rework the typescript configs across the whole project to catch these things, turn on strict mode, etc…
…diagnostics.test.js Co-authored-by: Robin Malfait <malfait.robin@gmail.com>
…diagnostics.test.js Co-authored-by: Robin Malfait <malfait.robin@gmail.com>
packages/tailwindcss-language-service/src/diagnostics/getInvalidSourceDiagnostics.ts
Outdated
Show resolved
Hide resolved
packages/tailwindcss-language-service/src/util/language-blocks.ts
Outdated
Show resolved
Hide resolved
packages/tailwindcss-language-server/tests/document-links/document-links.test.js
Show resolved
Hide resolved
This is actually valid except for Vite
We still want to diagnose theme functions in the media query list of an import which we do here.
RobinMalfait
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mades a fair number of changes to improve the developer experience in v4. Most of it is related to
@sourceandsource(…)but there are some additional tweaks:@import "…" source(…)does not issue syntax warnings@import "…" theme(…)does not issue syntax warnings@import "…" prefix(…)does not issue syntax warnings@tailwind utilities source(…)isn't diagnosed as invalid@themeoptions@import "…" theme(…)optionssource(…)@source "…"@config,@plugin, and@source@source@import "…" source(…)properly@import "…" theme(…)properly@import "…" prefix(…)properly@tailwind utilities source(…)properlysource(none)explicitlysource("…")@source,@config, and@plugin@source noneis invalid@source noneas invalid (theme-dependent)source(…)is not passed anythingsource(none)is mispelled@tailwind baseor@tailwind components@sourceandsource(…)@tailwind baseis used in a v4 project@tailwind preflightis used in a v4 project@tailwind componentsis used in a v4 project@tailwind screensis used in a v4 project@tailwind variantsis used in a v4 projectI had some stretch goals but I don't think I'll get to them in this PR unless we think they're important enough to hold up the PR:
@sourceglobs@source@import "tailwindcss/tailwind"@import "tailwindcss/tailwind.css"@source "…"stringssource(none)when typingsource(…)