Always use 1rem = 16px for pixel equivalents in media queries
#1190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // initial value of font-size as provided by the browser. This is defaults to 16px universally | ||
| // so we'll show them *if* the root font size is 16px otherwise we'd be showing potentially | ||
| // incorrect values. | ||
| if (rootFontSize !== 16) return query |
There was a problem hiding this comment.
Should we instead always set it to 16 for media queries? As in, don't accept a rootFontSize in the function and hardcode it to 16
There was a problem hiding this comment.
Ah you know… maybe
rootFontSize is not 16px1rem = 16px for pixel equivalents in media queries
RobinMalfait
approved these changes
Feb 11, 2025
philipp-spiess
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1189
From the CSS spec:
We should hide these because
1remeverywhere else will be one value but1remin a media query might still be 16px (it's not changeable by websites — only browsers / users)