Skip to content

Add Tailwind CSS language mode tests #1216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 21, 2025
Merged

Add Tailwind CSS language mode tests #1216

merged 8 commits into from
Feb 21, 2025

Conversation

thecrypticace
Copy link
Contributor

@thecrypticace thecrypticace commented Feb 17, 2025 •
edited
Loading

This PR does a small bit of refactoring on the bundled CSS language server and adds tests for it to ensure we don't break stuff

@thecrypticace thecrypticace mentioned this pull request Feb 17, 2025
Merged
@thecrypticace thecrypticace force-pushed the feat/css-server-tests branch 5 times, most recently from 32d1e17 to 6239d03 Compare February 20, 2025 21:17
@thecrypticace thecrypticace marked this pull request as ready for review February 20, 2025 21:17
@thecrypticace thecrypticace changed the base branch from main to feat/new-testing-setup February 20, 2025 21:21
@thecrypticace thecrypticace marked this pull request as draft February 20, 2025 21:43
@thecrypticace thecrypticace force-pushed the feat/css-server-tests branch 2 times, most recently from 0a89777 to 58e0be9 Compare February 20, 2025 22:04
@thecrypticace thecrypticace marked this pull request as ready for review February 20, 2025 22:32
RobinMalfait
RobinMalfait approved these changes Feb 21, 2025
View reviewed changes
Copy link
Member

@RobinMalfait RobinMalfait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not 100% sure how to test it properly apart from running it locally in vscode and it seems to work as expected.

Also looks like most of it is moving things around + cleanup.

Additional tests are also nice and no older tests break so that also a win.

packages/tailwindcss-language-server/src/language/css-server.ts
})

connection.onInitialize((params: InitializeParams) => {
workspaceFolders = (<any>params).workspaceFolders
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I've ever used a cast like that in TypeScript ever haha. Think I always do this:

Suggested change
workspaceFolders = (<any>params).workspaceFolders
workspaceFolders = (params as any).workspaceFolders

Just a comment, no change required though.

Base automatically changed from feat/new-testing-setup to main February 21, 2025 13:57
@thecrypticace thecrypticace merged commit f37a144 into main Feb 21, 2025
@thecrypticace thecrypticace deleted the feat/css-server-tests branch February 21, 2025 13:58
thecrypticace added a commit that referenced this pull request Feb 21, 2025
@thecrypticace @tizu69 @RobinMalfait
Don't show syntax error for *s inside --value and --modifier fu…
dd79be3 
…nctions (#1215)

Fixes #1208

Needs infrastructure from #1216 and tests

---------

Co-authored-by: tizu69 <60812901+tizu69@users.noreply.github.com>
Co-authored-by: Robin Malfait <malfait.robin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobinMalfait RobinMalfait RobinMalfait approved these changes

@philipp-spiess philipp-spiess Awaiting requested review from philipp-spiess

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thecrypticace @RobinMalfait