v4: Support loading bundled versions of some first-party plugins #1240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipp-spiess
approved these changes
Feb 27, 2025
| // If the request was to load a first-party plugin and we can't resolve it | ||
| // locally, then fall back to the built-in plugins that we know about. | ||
| if (resourceType === 'plugin' && id in plugins) { | ||
| console.log('Loading bundled plugin for: ', id) |
There was a problem hiding this comment.
Did you keep these logs on purpose?
There was a problem hiding this comment.
Yep. We send these to the "Tailwind CSS IntelliSense" output panel in VSCode. It's useful for triaging issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #1224 (comment)
This adds support for loading these three plugins in v4 only when using
@pluginif we can't find them:@tailwindcss/typography@tailwindcss/forms@tailwindcss/aspect-ratioThis coincides with behavior of the Standalone CLI where these are bundled instead of available as an NPM package.
I've additionally logs when trying to import one of these plugins inside a JS file. This does not work right now and may take some effort to support because it will at least require the use of Node's experimental loader's API and potentially additional work as well.