Skip to content

Don’t throw when client is missing the textDocument capability #1252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 12, 2025

Conversation

thecrypticace
Copy link
Contributor

@thecrypticace thecrypticace commented Mar 5, 2025

Fixes #1251

This needs more research before merging because we probably need to skip registration of providers. And possibly not even attempt to initialize projects in this case? Not entirely sure.

  • Needs tests

@thecrypticace thecrypticace marked this pull request as ready for review March 11, 2025 21:02
@thecrypticace
Copy link
Contributor Author

I'm gonna skip the automated tests for now. I can't find anything reasonable in the language server spec about how things should act in this case so I'm just gonna wait for people to open an issue if that ever happens.

@thecrypticace thecrypticace force-pushed the fix/no-throw-missing-textdocument-capability branch from cb105ae to 7798c1e Compare March 12, 2025 13:30
@thecrypticace thecrypticace merged commit 07da721 into main Mar 12, 2025
@thecrypticace thecrypticace deleted the fix/no-throw-missing-textdocument-capability branch March 12, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Language Server throws when textDocument client capability is missing
3 participants