v4: Show completions after any valid variant #1263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b148c18 to
06df6d5
Compare
f086f81 to
63c0f68
Compare
RobinMalfait
approved these changes
Mar 18, 2025
We weren’t handling the case of arbitrary variants, variants with an arbitrary value, and variants with bare values. We have to compile a dummy class temporarily to determine whether or not the class is valid
63c0f68 to
c660b19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #943
Fixes #1257
This doesn't ensure variants like
not-supports-*are suggested becausenot-supports:isn't valid. Only something with a value is e.g.not-supports-display. Making that work (it really should) is a larger task and requires designing an interactive suggestion API for v4.