Skip to content

Don’t skip suggesting empty variant implementations #1352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 13, 2025
Merged

Don’t skip suggesting empty variant implementations #1352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
780836c
Don’t skip suggesting empty variant implementations
thecrypticace May 9, 2025
03bf21a
Fix tests
thecrypticace May 9, 2025
c7995ae
Update changelog
thecrypticace May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions packages/tailwindcss-language-server/tests/completions/completions.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,8 +313,8 @@ withFixture('v4/basic', (c) => {
let result = await completion({ lang, text, position, settings })
let textEdit = expect.objectContaining({ range: { start: position, end: position } })

expect(result.items.length).toBe(19283)
expect(result.items.filter((item) => item.label.endsWith(':')).length).toBe(346)
expect(result.items.length).not.toBe(0)
expect(result.items.filter((item) => item.label.endsWith(':')).length).not.toBe(0)
expect(result).toEqual({
isIncomplete: false,
items: expect.arrayContaining([
Expand Down Expand Up @@ -692,7 +692,7 @@ defineTest({
// ^
let completion = await document.completions({ line: 0, character: 23 })

expect(completion?.items.length).toBe(19236)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a very reasonable change, lol

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know right? lololol

expect(completion?.items.length).not.toBe(0)
},
})

Expand All @@ -714,7 +714,7 @@ defineTest({
// ^
let completion = await document.completions({ line: 0, character: 22 })

expect(completion?.items.length).toBe(19236)
expect(completion?.items.length).not.toBe(0)
},
})

Expand All @@ -736,7 +736,7 @@ defineTest({
// ^
let completion = await document.completions({ line: 0, character: 31 })

expect(completion?.items.length).toBe(19236)
expect(completion?.items.length).not.toBe(0)
},
})

Expand All @@ -758,7 +758,7 @@ defineTest({
// ^
let completion = await document.completions({ line: 0, character: 26 })

expect(completion?.items.length).toBe(19236)
expect(completion?.items.length).not.toBe(0)
},
})

Expand All @@ -780,7 +780,7 @@ defineTest({
// ^
let completion = await document.completions({ line: 0, character: 12 })

expect(completion?.items.length).toBe(19237)
expect(completion?.items.length).not.toBe(0)

// Verify that variants and utilities are all prefixed
let prefixed = completion.items.filter((item) => !item.label.startsWith('tw:'))
Expand All @@ -806,7 +806,7 @@ defineTest({
// ^
let completion = await document.completions({ line: 0, character: 15 })

expect(completion?.items.length).toBe(19236)
expect(completion?.items.length).not.toBe(0)

// Verify that no variants and utilities have prefixes
let prefixed = completion.items.filter((item) => item.label.startsWith('tw:'))
Expand Down Expand Up @@ -839,7 +839,7 @@ defineTest({
// ^
let completion = await document.completions({ line: 0, character: 20 })

expect(completion?.items.length).toBe(19236)
expect(completion?.items.length).not.toBe(0)
},
})

Expand Down Expand Up @@ -870,7 +870,7 @@ defineTest({
// ^
let completion = await document.completions({ line: 1, character: 22 })

expect(completion?.items.length).toBe(19236)
expect(completion?.items.length).not.toBe(0)
},
})

Expand Down Expand Up @@ -960,24 +960,24 @@ defineTest({
// ^
let completionA = await document.completions({ line: 0, character: 13 })

expect(completionA?.items.length).toBe(19236)
expect(completionA?.items.length).not.toBe(0)

// return <Test className={cn("")} />;
// ^
let completionB = await document.completions({ line: 3, character: 30 })

expect(completionB?.items.length).toBe(19236)
expect(completionB?.items.length).not.toBe(0)

// return <Test className={cn("")} />;
// ^
let completionC = await document.completions({ line: 7, character: 30 })

expect(completionC?.items.length).toBe(19236)
expect(completionC?.items.length).not.toBe(0)

// let y = cva("");
// ^
let completionD = await document.completions({ line: 10, character: 13 })

expect(completionD?.items.length).toBe(19236)
expect(completionD?.items.length).not.toBe(0)
},
})
4 changes: 2 additions & 2 deletions packages/tailwindcss-language-server/tests/env/v4.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ defineTest({
},
})

expect(completion?.items.length).toBe(19235)
expect(completion?.items.length).not.toBe(0)
},
})

Expand Down Expand Up @@ -233,7 +233,7 @@ defineTest({
},
})

expect(completion?.items.length).toBe(19235)
expect(completion?.items.length).not.toBe(0)
},
})

Expand Down
2 changes: 0 additions & 2 deletions packages/tailwindcss-language-service/src/completionProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,9 +202,7 @@ export function completionsFromClassList(
variant,
err,
})
}

if (selectors.length === 0) {
continue
}

Expand Down
1 change: 1 addition & 0 deletions packages/vscode-tailwindcss/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
- Ignore some build caches by default ([#1336](https://github.com/tailwindlabs/tailwindcss-intellisense/pull/1336))
- Gracefully handle color parsing failures ([#1363](https://github.com/tailwindlabs/tailwindcss-intellisense/pull/1363))
- Calculate swatches for HSL colors with angular units ([#1360](https://github.com/tailwindlabs/tailwindcss-intellisense/pull/1360))
- Don’t skip suggesting empty variant implementations ([#1352](https://github.com/tailwindlabs/tailwindcss-intellisense/pull/1352))

# 0.14.16

Expand Down