Skip to content

Simplify details for utility completions #1356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 13, 2025

Conversation

thecrypticace
Copy link
Contributor

Fixes #1347

This PR addresses two problems (see screenshots below):

  1. Utilities that generate @property rules will include the declarations from @property in the completion details.
  2. Custom variants that include declarations will include those declarations in the completion details.

To fix these we are now:

  1. Generating details using the "base" utility
  2. Dropping any uses of @property before calculating the list of declarations

Before
Screenshot 2025-05-09 at 18 08 57

Screenshot 2025-05-09 at 18 10 12

After
Screenshot 2025-05-09 at 18 11 36

Screenshot 2025-05-09 at 18 12 46

Note that the "documentation" portion of completion items is unchanged and shows the full candidate with all the CSS included (for non-color utilities):

Screenshot 2025-05-09 at 18 14 53

@thecrypticace thecrypticace merged commit c080688 into main May 13, 2025
12 checks passed
@thecrypticace thecrypticace deleted the feat/completions-variants-static-decls branch May 13, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Negative impact of including static declarations in custom variants
2 participants