Don't register ability to hover, request colors, etc… more than once #1378
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're currently re-registering "common" capabilities per workspace folder. This causes VSCode to make multiple requests to the server for things like hover causing higher CPU usage. This then results multiple hovers being displayed. What's worse is that for some scenarios where the server has to internally do a restart the old registrations weren't getting disposed of because of a race condition when calling it concurrently for multiple folders.
I've done two things to address this:
This should mean that this only happens one time per server initialization.
Fixes #1371