Fix edit range being incorrect when utilities contain variants #1480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b55702b to
fce39d2
Compare
fce39d2 to
f53845d
Compare
RobinMalfait
approved these changes
Oct 21, 2025
thecrypticace
added a commit
to tailwindlabs/tailwindcss
that referenced
this pull request
Oct 22, 2025
Fixes tailwindlabs/tailwindcss-intellisense#1479 Maybe should close tailwindlabs/tailwindcss-intellisense#1480 — perhaps we can find a workaround there for older versions? We're building up a class name in code to validate if something is a valid variant: `{variant}:[color:red]` if `{variant}` got replaced with `bg-[` then we'd produce `bg-[:[color:red]` and this parsed as a valid candidate: ``` bg-[:[color:red] ^^ root: `bg` ^ data type: `` (empty string) — this should be invalid ^^^^^^^^^^ value: `[color:red` ``` The value isn't valid _but_ the syntax for arbitrary values is pretty lax in core. Oxide already won't pick something like this up though so no problem there. Only a problem for something like IntelliSense or clients using the compile() API directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1479
This is the result of a parsing issue inside core which causes us to make incorrect assumptions. See tailwindlabs/tailwindcss#19172
The tl;dr of how this bug happened:
hover:bg-[and each "part" gets tested{part}:[color:red]hoverand it passes — awesome ✅bg-[and it passes — bad ❌bg-[:[color:red]and was incorrectly parsed as a valid utility. This is fixed in Tailwind CSS v4.1.16This meant that the start position was after the end position for a completion's edit range because it assumed there was a separator (
:) after thebg-[part when there is not.We'll work around this for old versions. As mentioned new Tailwind CSS versions will handle this appropriately.