feat: Yarn PnP support #175
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanSnow
commented
Aug 23, 2020
| @@ -154,7 +134,6 @@ export default async function getClassNames( | |||
| browserslist, | |||
| }), | |||
| modules: { | |||
| tailwindcss, | |||
There was a problem hiding this comment.
I removed the tailwindcss here because it won't work without the PnP environment
|
Wow this is amazing, thanks so much for this @DanSnow! Going to take a look 👍 |
DanSnow
commented
Aug 27, 2020
Comment on lines
+79
to
+80
| } catch (error) { | ||
| throw error |
There was a problem hiding this comment.
try { ... } finally { ... } won't swallow the error.
There was a problem hiding this comment.
Oh cool sorry, my bad 👍 Never seen that before. Feel free to change it back
There was a problem hiding this comment.
This doesn't work on yarn workspaces, but works on root project...
There was a problem hiding this comment.
Sorry, it does work, but make sure to include:
{
purge: ['./pages/**/*.{js,jsx,ts,tsx}'],
}
in your tailwind.config.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this extension! It's really useful.
resolved #160