Skip to content

Remove logging conflicting with language server output #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Remove logging conflicting with language server output #263

wants to merge 1 commit into from

Conversation

agorgl
Copy link

@agorgl agorgl commented Feb 11, 2021

Similar to issue #91 opened and solved in the past.
We must not put console.log stdout outputs as this conflicts with the language server when running on --stdio mode.

Proposed fix tested and working with vim-lsp.

@agorgl agorgl mentioned this pull request Feb 11, 2021
@bradlc
Copy link
Contributor

bradlc commented Feb 12, 2021

Thanks @elartista. I didn't want to remove these logs so I have overridden console.log and console.error, based on code from vscode-json-languageserver. This seems to fix the issue in Nova but let me know if you're still running into issues.

@bradlc bradlc closed this Feb 12, 2021
predragnikolic added a commit to sublimelsp/LSP-tailwindcss that referenced this pull request Feb 19, 2021
Sorry for the last two commit messages
I just wanted to get the server up to a usable state.

Before this PR, the server couldn't be initialized successfuly.

Luckily, some good soul fixed the issue,
tailwindlabs/tailwindcss-intellisense#263

but the maintainer didn't published yet a release with that fix,
so I manually compiled the tailwindcss-intellisense repo,
and included the fix with this PR.

So everything should be good now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants