Fix build due to invalid default Settings
#287
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #274, a file was preventing an errror-less build because an experimental setting was missing. I supplied a default value for the field.
However, upon fixing it I found that the underlying type
Settings
had been compiled with some previous version of the type that failed to includes the following properties:showPixelEquivalents
rootFontSize
The file that declares the type,
state.ts
, was already updated to hold those properties, so I re-built the language server. This fixed the two fields above, but the experimental setting was gone this time. To fix the final error, I added that field to the original type definition instate.ts
.Likely to completely fix this, you would need to re-release the language server and update the extension's version.