Skip to content

Fix build due to invalid default Settings #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix build due to invalid default Settings #287

wants to merge 1 commit into from

Conversation

misha
Copy link

@misha misha commented Mar 29, 2021

As mentioned in #274, a file was preventing an errror-less build because an experimental setting was missing. I supplied a default value for the field.

However, upon fixing it I found that the underlying type Settings had been compiled with some previous version of the type that failed to includes the following properties:

  1. showPixelEquivalents
  2. rootFontSize

The file that declares the type, state.ts, was already updated to hold those properties, so I re-built the language server. This fixed the two fields above, but the experimental setting was gone this time. To fix the final error, I added that field to the original type definition in state.ts.

Likely to completely fix this, you would need to re-release the language server and update the extension's version.

@agorgl
Copy link

agorgl commented Mar 30, 2021

Bumped into this too, waiting a long time to get this fixed

@bradlc
Copy link
Contributor

bradlc commented May 18, 2021

Hey @misha. Sorry for the delay. I don't think this is relevant anymore, but thanks anyway! 🙏

@bradlc bradlc closed this May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants