Skip to content

Fix EEx support (for elixir/phoenix) #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 6, 2019
Merged

Fix EEx support (for elixir/phoenix) #54

merged 2 commits into from
Aug 6, 2019

Conversation

@praveenperera
Copy link
Contributor

@praveenperera praveenperera commented Jun 12, 2019

No description provided.

bradlc
bradlc reviewed Jun 12, 2019
View reviewed changes
@praveenperera @bradlc
Support mjmcloug.vscode-elixir and jakebecker.elixir-ls extensions
e40f46e 
Co-Authored-By: Brad Cornes <bradlc41@gmail.com>
@bradlc
Copy link
Contributor

bradlc commented Jun 12, 2019

Thanks @praveenperera! I will get this released shortly

@praveenperera
Copy link
Contributor Author

praveenperera commented Jun 12, 2019 •
edited
Loading

@bradlc Does this change also need to be made in the tailwindcss-language-server file?

After this change the hover hints work, but the autocomplete still does not.

@dhc02
Copy link
Contributor

dhc02 commented Jul 18, 2019

@praveenperera I think this change is all that's needed, although I had to quit and restart VS Code to get it to scan the project for classes and start autocompleting.

@praveenperera
Copy link
Contributor Author

praveenperera commented Jul 18, 2019 •
edited
Loading

Good to know it’s working for you @dhc02. It worked for me after a restart too.

Can we get this merged in? @bradlc ?

@bradlc bradlc merged commit 0e2bc79 into tailwindlabs:master Aug 6, 2019
@praveenperera praveenperera mentioned this pull request Aug 26, 2019
Closed
praveenperera added a commit to praveenperera/vscode-tailwindcss that referenced this pull request Sep 26, 2019
@praveenperera
Fix EEx support (for elixir/phoenix) (tailwindlabs#54)
c2803b1
@frankdugan3
Copy link

frankdugan3 commented Jan 12, 2020

@bradlc Any chance we could get a release that includes this merge?

@frankdugan3 frankdugan3 mentioned this pull request Jan 12, 2020
Closed
@ghost ghost mentioned this pull request Mar 17, 2020
Closed
@ghost
Copy link

ghost commented Mar 17, 2020 •
edited by ghost
Loading

Not working in Version: 1.43.0
only have https://marketplace.visualstudio.com/items?itemName=mjmcloug.vscode-elixir enabled which is required for HTML (Eex) for adding the HTML_LANGUAGES string

Edit: now seeing this has not been released. 🤦‍♂ my bad.

@praveenperera praveenperera deleted the patch-1 branch March 17, 2020 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bradlc bradlc bradlc left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@praveenperera @bradlc @dhc02 @frankdugan3