Fix client not starting (#608)

[fbalda]

Fixes #608 where the extension client (sometimes?) doesn't start after restarting VSCode.
Workspace.createFileSystemWatcher doesn't seem to create events for already existing files when starting VSCode so an initial scan for config files is necessary.

[bradlc]

Hey @fbalda. We already do this when opening a document (and on activation for already opened files):

tailwindcss-intellisense/packages/vscode-tailwindcss/src/extension.ts

Lines 696 to 697 in a740b0e

	context.subscriptions.push(Workspace.onDidOpenTextDocument(didOpenTextDocument))
	Workspace.textDocuments.forEach(didOpenTextDocument)

tailwindcss-intellisense/packages/vscode-tailwindcss/src/extension.ts

Lines 645 to 649 in a740b0e

	let [configFile] = await Workspace.findFiles(
	new RelativePattern(folder, `**/${CONFIG_GLOB}`),
	`{${getExcludePatterns(folder).join(',')}}`,
	1
	)

Were you able to identify exactly why the existing bootClientForFolderIfNeeded function doesn't boot the server for your project?

[fbalda]

Hey @bradlc, yeah I totally missed that, sorry for the premature PR, shouldn't have rushed it.
I am investigating right now and it seems that

tailwindcss-intellisense/packages/vscode-tailwindcss/src/extension.ts

Lines 645 to 649 in a740b0e

	let [configFile] = await Workspace.findFiles(
	new RelativePattern(folder, `**/${CONFIG_GLOB}`),
	`{${getExcludePatterns(folder).join(',')}}`,
	1
	)

fails for me, I get:
error parsing glob '!/{/.git,/.svn,/.hg,/CVS,/.DS_Store,/Thumbs.db,"/*.js": { "when": "$(basename).ts" },/.classpath,/.project,/.settings,/.factorypath,/.git/,/node_modules/,/.hg/,/.svn/**}': nested alternate groups are not allowed

The { "when": "$(basename).ts" } in my settings.json seems to break it, removing the curly brackets in the template string for the exclude pattern {${getExcludePatterns(folder).join(',')}} fixes the issue for me

EDIT: Did some quick tests to confirm that the curly brackets are indeed not needed, the exclude pattern will work without them

[bradlc]

Can you share your full VS Code settings in JSON format please @fbalda?

[fbalda]

@bradlc Sure, here you go:

{
"settingsSync.ignoredSettings": [
"cmake.cmakePath",
"clang-format.executable"
],
"settingsSync.ignoredExtensions": ["apple-swift-format.path"],
"cmake.cmakePath": "/opt/homebrew/bin/cmake",
"clang-format.executable": "/opt/homebrew/opt/llvm/bin/clang-format",
"apple-swift-format.path": "/opt/homebrew/Cellar/swift-format/0.50500.0/bin/swift-format",
"[typescriptreact]": {
"editor.defaultFormatter": "esbenp.prettier-vscode"
},
"[typescript]": {
"editor.defaultFormatter": "esbenp.prettier-vscode",
"editor.codeActionsOnSave": {
"source.organizeImports": false
}
},
"editor.formatOnSave": true,
"editor.codeActionsOnSave": {
"source.organizeImports": false
},
"git.autofetch": true,
"[javascript]": {
"editor.defaultFormatter": "esbenp.prettier-vscode"
},
"explorer.confirmDelete": false,
"files.exclude": {
""/*.js": { "when": "$(basename).ts" }": true,
"/.classpath": true,
"/.project": true,
"/.settings": true,
"**/.factorypath": true
},
"[html]": {
"editor.defaultFormatter": "esbenp.prettier-vscode"
},
"cmake.configureOnOpen": true,
"[cpp]": {
"editor.defaultFormatter": "xaver.clang-format"
},
"[c]": {
"editor.defaultFormatter": "xaver.clang-format"
},
"explorer.confirmDragAndDrop": false,
"window.titleBarStyle": "custom",
"git.confirmSync": false,
"tslint.enable": false,
"eslint.format.enable": false,
"eslint.enable": true,
"typescript.validate.enable": true,
"javascript.validate.enable": false,
"redhat.telemetry.enabled": false,
"workbench.colorTheme": "One Dark Pro Darker",
"editor.fontFamily": "Fira Code",
"editor.fontLigatures": true,
"terminal.integrated.fontFamily": "monospace",
"editor.suggestSelection": "first",
"vsintellicode.modify.editor.suggestSelection": "automaticallyOverrodeDefaultValue",
"java.imports.gradle.wrapper.checksums": [
{
"sha256": "e2b82129ab64751fd40437007bd2f7f2afb3c6e41a9198e628650b22d5824a14",
"allowed": false
}
],
"[swift]": {
"editor.defaultFormatter": "vknabel.vscode-swiftformat"
},
"[java]": {
"editor.defaultFormatter": "redhat.java"
},
"[json]": {
"editor.defaultFormatter": "esbenp.prettier-vscode"
},
"npm.packageManager": "npm",
"diffEditor.ignoreTrimWhitespace": false,
"sql-formatter.uppercase": true,
"[sql]": {
"editor.defaultFormatter": "adpyke.vscode-sql-formatter"
},
"cSpell.userWords": [
"Balda",
"Bootloader",
"Framebuffer",
"glsl",
"LUNARG",
"pwhash",
"Rasterization",
"rasterized",
"Signup",
"swapchain",
"totp",
"Vulkan"
],
"lldb.library": "/Applications/Xcode.app/Contents/SharedFrameworks/LLDB.framework/Versions/A/LLDB",
"[scss]": {
"editor.defaultFormatter": "esbenp.prettier-vscode"
},
"window.zoomLevel": -1,
"glsllint.glslifyUseCurrentFileAsBasedir": true,
"glsllint.glslifyAutoOpenOnError": false,
"glsllint.linkShader": false,
"[glsl]": {
"editor.defaultFormatter": "xaver.clang-format"
},
"editor.quickSuggestions": {
"strings": true
},
"editor.inlineSuggest.enabled": true,
"css.validate": false,
"[css]": {
"editor.defaultFormatter": "esbenp.prettier-vscode"
},
"[jsonc]": {
"editor.defaultFormatter": "esbenp.prettier-vscode"
}
}

[bradlc]

Thank you! I'm pretty sure your files.exclude config is malformed, which is causing the issue. I'm getting a similar error from GitHub Copilot with your config:

Here's how I think you meant to configure it:

  "files.exclude": {
-   "\"**/*.js\": { \"when\": \"$(basename).ts\" }": true,
+   "**/*.js": { "when": "$(basename).ts" },
    "**/.classpath": true,
    "**/.project": true,
    "**/.settings": true,
    "**/.factorypath": true
  }

Can you confirm whether this fixes your issue?

[fbalda]

It does indeed, thank you!
Interestingly I am pretty sure this was configured by some plugin (as I rarely work with globs) and it never caused any issues for me, leading me to assume my config was valid.
Sorry for the inconvenience and thank you for your work. Closing this