Improved performance #779
Closed
Improved performance #779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome work man! |
|
Hey @MaximilianLloyd, thanks for the PR. On this occasion I'm going to leave this as it is for now, because I'm not seeing any performance improvement on my end and I don't want to make changes like this if there isn't a significant benefit. I hope that's understandable! As a side note, I believe the numbers you shared are in milliseconds, not seconds, so the improvement you are seeing is 0.1ms, not 100ms. |
|
My bad, sorry for the inconvenience 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved performance by avoid resizing matches array. This seems to provide a quite healthy performance improvement across the board.
I did some performance tracking with
node:perf_hooksThe first block is without my modifications, just tracking the performance. The second is with my changes. I tested it by modifying the className with exactly the same values. With my changes it seems that around 100-150~ms are sliced off on many calls.