Skip to content

Remove duplicate variant + value pairs from completions #874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 27, 2023

Conversation

thecrypticace
Copy link
Contributor

@thecrypticace thecrypticace commented Oct 27, 2023

This happens if you register variant like peer-hover because Tailwind itself defines a peer variant that has several values — one of which is hover.

Basically, this config no longer produces multiple completions for peer-hover:

export default {
  plugins: [
    ({ addVariant }) => {
      addVariant("peer-hover", "[data-hoverable] .peer:hover ~ &");
    }
  ]
}

Fixes tailwindlabs/tailwindcss#12187

@thecrypticace thecrypticace force-pushed the fix/no-duplicate-variants branch 5 times, most recently from 91eba41 to 7cc4af7 Compare October 27, 2023 15:30
@thecrypticace thecrypticace force-pushed the fix/no-duplicate-variants branch from 7cc4af7 to c6364ce Compare October 27, 2023 16:02
@thecrypticace thecrypticace merged commit 2caebd1 into master Oct 27, 2023
@thecrypticace thecrypticace deleted the fix/no-duplicate-variants branch October 27, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom variant not "hiding" built-in variant of same name
1 participant