Fix loading projects on network drives #996
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening a project on a networked drive (e.g.
Z:\my-project
) would fail because:\\MyShare\some-folder\my-project
)enhanced-resolve
with UNC pathsAdditionally, opening projects on a network share directly (rather than a mapped network drive) would always fail to discover any projects.
I've made some improvements to file path handling such that:
enhanced-resolve
when resolving relative file pathsfs.realpath
and uses the url that was passed in. This means that symlinks don't get resolved however it should (hopefully) solve most issues when using Intellisense with projects over the networkFixes #994