This repository was archived by the owner on Apr 6, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did I provide a test: YES
Do the tests pass: YES
Is this ready to merge: NO
I used what Adam did in #99 as inspiration for this PR.
I have updated the tests to include a proposed acceptance, though there is still more work to be done to add this support to the other utility classes. The test is definitely brittle.
Since this swaps out
asLength
forasValue
, I'm guessing that might break something else in the framework, though the tests in this repo did not break. ¯\_(ツ)_/¯I couldn't wrap my head around most of the source code, but I noticed in the
asValue()
helper function, that there is some special stuff going on forcalc()
. I wonder if all of the CSS functions could be supported using a similar method?I also wonder if you can use
asLength
first, and if that returnsundefined
to then instead try and look for a supported list of arbitrary CSS functions? I know #102 mentions usingvar()
and my example isclamp()
As a slight tangent, I think this would be super valuable to include, because of the utility of these arbitrary function values. Functions like
clamp
/min
/max
etc are extremely helpful for building custom one off design elements.Great work on the JIT; Overall, it's awesome 🤘