This repository was archived by the owner on Apr 6, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #107
chokidar
andfast-glob
both expect paths to use forward slashes.Because we use
path.resolve
to define the purge paths in our tests, this results in Windows-style paths when running on Windows. This caused the issue described in #107.This PR uses
normalize-path
to ensure that the paths passed tochokidar
andfast-glob
are what they expect.Alternatives
We could use
normalize-path
in our tests, and make it clear in the docs that thepurge
paths should use forward slashes, but this PR means that people can do stuff like we did in the tests without worrying about it: