This repository was archived by the owner on Apr 6, 2021. It is now read-only.
Recursive apply #136
Merged
Recursive apply #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently what it will do is re-run the apply code. If it turns out that there are @apply rules left, then it will re-apply those. If there are no @apply rules left, this means that we are "done". One big downside is that we are (at the time of this commit) running the apply code for the test at least 4 times. The good part is that we are doing it on the exact same tree so we don't need to re-parse it. This is the first implementation which can be improved!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a naive implementation of the recursive
@apply.We can improve this if this causes actual issues.
For example, currently in the tests are are running through the plugin 4 times.
If we create a dependency graph instead, then we could do a topological sort so that we only have to loop through the apply plugin once.
This improvement will also make it easier to detect cycles (currently we would loop forever).
Fixes: #66