Fix multiple @apply involving responsive rules #151

thecrypticace · 2021-03-24T01:22:47Z

Builds on #150 (so lets get that merged first and then I'll rebase this)

Closes #148

RobinMalfait

Hey! Thank you for your PR!
Much appreciated! 🙏

Little nitpick, but apart from that, looks correct to me, thanks!

We'll wait for the other PR to be merged first (#150)

src/lib/expandApplyAtRules.js

We achieve this by: 1. handling applies on a per-parent basis 2. Splitting @apply a b c into @apply a; @apply b; @apply c; (in that order) and then sorting all applies in a given node

Co-authored-by: Robin Malfait <malfait.robin@gmail.com>

RobinMalfait suggested changes Mar 24, 2021

View reviewed changes

src/lib/expandApplyAtRules.js Outdated Show resolved Hide resolved

thecrypticace and others added 2 commits March 24, 2021 09:10

Fix multiple @apply of responsive rules

53092ea

We achieve this by: 1. handling applies on a per-parent basis 2. Splitting @apply a b c into @apply a; @apply b; @apply c; (in that order) and then sorting all applies in a given node

Use destructing when looping over candidates

52e9976

Co-authored-by: Robin Malfait <malfait.robin@gmail.com>

adamwathan force-pushed the fix/multiple-apply-responsive branch from c4295a9 to 52e9976 Compare March 24, 2021 13:10

adamwathan merged commit d55078d into main Mar 24, 2021

adamwathan deleted the fix/multiple-apply-responsive branch March 24, 2021 13:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix multiple @apply involving responsive rules #151

Fix multiple @apply involving responsive rules #151

thecrypticace commented Mar 24, 2021

RobinMalfait left a comment

Fix multiple @apply involving responsive rules #151

Fix multiple @apply involving responsive rules #151

Conversation

thecrypticace commented Mar 24, 2021

RobinMalfait left a comment

Choose a reason for hiding this comment