This repository was archived by the owner on Apr 6, 2021. It is now read-only.
Bug fixes / improvements #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When sorting based on the BigInt values, we are doing `Number(a - z)`, but if the result of `a - z` is bigger then the max number, then overflows would happen. This will result in a hard-to-debug bug. This is a prevention for the future, because currently all our `a - z` values will not reach Number.MAX_SAFE_INTEGER mark (9007199254740991).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@applyso that we skip twice the work in replacing that selector.The sort bug could happen once we have ~50 variants, which is not that unrealistic if you think about user defined variants.
I'm saying ~50 because we also have an offset.