This repository was archived by the owner on Apr 6, 2021. It is now read-only.
[Draft] Fix webpack 5 persistent cache invalidation #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we’re recording these as dependencies we must have the absolute paths. If we don’t they may (and generally will) be resolved incorrectly.
This makes for easier debugging so we can touch the file manually to see if it triggers a rebuild. Or to see if it was properly deleted when the process exited.
These are not always removed on process exit and definitely not removed when rebooting the watcher.
|
This was superseded by the other PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a couple of things we do here:
TODO: Figure out how to handle files that were added between builds. The general way to do this would be to register whole directories as build dependencies with webpack however doing so requires a webpack plugin.TODO: This looks like causes the cache pack file to be invalidated when recompiling so new files are picked up. I do not know why this is however so I need to be sure it doesn't break in the future.