This repository was archived by the owner on Apr 6, 2021. It is now read-only.
Apply part 2 #7
Merged
Apply part 2 #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinMalfait
commented
Mar 3, 2021
Comment on lines
+112
to
+119
| .dark .dark\:group:hover .apply-dark-group-example-a { | ||
| --tw-bg-opacity: 1; | ||
| background-color: rgba(16, 185, 129, var(--tw-bg-opacity)); | ||
| } | ||
| .group:hover .group-hover\:dark .apply-dark-group-example-b { | ||
| --tw-bg-opacity: 1; | ||
| background-color: rgba(16, 185, 129, var(--tw-bg-opacity)); | ||
| } |
There was a problem hiding this comment.
This is not correct. I think it should be something like this:
Suggested change
| .dark .dark\:group:hover .apply-dark-group-example-a { | |
| --tw-bg-opacity: 1; | |
| background-color: rgba(16, 185, 129, var(--tw-bg-opacity)); | |
| } | |
| .group:hover .group-hover\:dark .apply-dark-group-example-b { | |
| --tw-bg-opacity: 1; | |
| background-color: rgba(16, 185, 129, var(--tw-bg-opacity)); | |
| } | |
| .dark .group:hover .apply-dark-group-example-a { | |
| --tw-bg-opacity: 1; | |
| background-color: rgba(16, 185, 129, var(--tw-bg-opacity)); | |
| } | |
| .dark .group:hover .apply-dark-group-example-b { | |
| --tw-bg-opacity: 1; | |
| background-color: rgba(16, 185, 129, var(--tw-bg-opacity)); | |
| } |
da0578a to
253fb51
Compare
Creating multiple siblings for each utility guarantees the order. We can optimize this by squashing adjacent rules with the same selector.
253fb51 to
b429c38
Compare
b429c38 to
0c3b46c
Compare
For full performance benefits!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.