This repository was archived by the owner on Apr 6, 2021. It is now read-only.
Refactor from custom tuple format to PostCSS nodes #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwathan
commented
Mar 5, 2021
| for (let result of plugin(modifier, pluginHelpers)) { | ||
| if (Array.isArray(result)) { |
There was a problem hiding this comment.
This is the little adapter layer, we can remove these conditionals when the plugins are refactored.
adamwathan
commented
Mar 5, 2021
e73604f to
217b1ed
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors everything to stop using our little rule tuple syntax and instead just use full PostCSS nodes everywhere. The simple format sounded nice at first but there are lots of things it doesn't handle (like comments, or even
@font-facerules) and it was starting to become apparent why PostCSS nodes are in the format they are 👀There were also many places in the code where we were starting with PostCSS, converting it to a tuple because that's what some other code expected, only to inevitably convert it back to PostCSS.
I still need to update all of the plugins to return PostCSS nodes directly, but for now there's a small layer in between to turn them into PostCSS nodes before they make contact with the rest of the system, so this is safe to merge as-is. I need to decide on the API for on-demand plugins and then I'll rework each one to return PostCSS nodes.