Update core package and config #16
Conversation
Many editors try to help with formatting. When local settings differ, it becomes a chore.
| module.exports = { | ||
| plugins: [ | ||
| require('tailwindcss'), | ||
| require('autoprefixer'), | ||
| ...process.env.NODE_ENV === 'production' | ||
| ...(process.env.NODE_ENV === 'production' | ||
| ? [purgecss, require('cssnano')] |
There was a problem hiding this comment.
The purgecss const was removed, so this will not work :)
| "cross-env": "^5.2.0", | ||
| "cssnano": "^4.1.10", | ||
| "live-server": "^1.2.1", | ||
| "postcss-cli": "^6.1.2" | ||
| "postcss-cli": "^7.1.1", | ||
| "tailwindcss": "^1.5.2" |
There was a problem hiding this comment.
Since Tailwind is included in the final build, I think it would be wise to move it to the dependencies, not devDependencies
| "autoprefixer": "^9.5.1", | ||
| "tailwindcss": "^1.0" | ||
| }, | ||
| "dependencies": {}, | ||
| "devDependencies": { | ||
| "@fullhuman/postcss-purgecss": "^1.2.0", |
There was a problem hiding this comment.
There is no need to include purgecss anymore as it comes bundled with tailwind already :)
| @@ -0,0 +1,11 @@ | |||
| # https://editorconfig.org | |||
There was a problem hiding this comment.
I don't think adding a config in this PR makes sense. I'd create a new PR with just the config. This increases the chances of the PR being merged 😉
|
Hey @colindensem Really sorry - just did an update to the versions of this playground and somehow missed this PR, which does similar things but a few versions earlier :/ Thanks for your submission - I wish I looked at this before making the decision to update this repo! |
Updates the core packages and associated configs for Tailwindcss 1.5.2
To address #13