Skip to content

Conversation

@omriluz
Copy link
Contributor

@omriluz omriluz commented Jun 17, 2023

Hey I'd like to add RTL support to Tailwind Typography, I think it's time to use logical operators to support multiple languages instead of only left to right languages, if any further fixes to my code are needed ill be glad to contribute as needed

@vercel
Copy link

vercel bot commented Jun 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tailwindcss-typography ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 17, 2023 9:11pm

@adamwathan
Copy link
Member

Hey thanks for the PR! Definitely not opposed to adding support for this but can't merge this PR as-is because the tests aren't passing. It looks like you've mistakenly updated some instances of left and right to be inline-start and inline-end that should not have been changed (for instance the test that tests the prose-ol:pl-6 class).

So going to close this as it can't be merged in its current state, but if you're up for fixing the issues here and opening a new PR where the test suite is passing we're happy to take another look! Sorry if this comes across as dismissive, we could do the work to get this into a mergeable state ourselves of course but we get so many contributions that if we defaulted to doing that we'd never have time to focus on our own priorities. Thanks!

@adamwathan adamwathan closed this Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants