Add arbitrary-variants section in arbitrary-values #1378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sleepful
commented
Oct 7, 2022
| @@ -116,9 +116,13 @@ This can be useful for things like CSS variables as well, especially when they n | |||
| </div> | |||
| ``` | |||
|
|
|||
| ### Arbitrary variants | |||
|
|
|||
| In the same vein as arbitrary values, **arbitrary variants** allow you to write custom CSS selector modifiers, please refer to [arbitrary variants](/docs/hover-focus-and-other-states#using-arbitrary-variants). | |||
There was a problem hiding this comment.
I added the bold here because it's easy to gloss over the words given how similar they are to arbitrary values.
|
Thanks! Made a couple of tweaks but I think it's good to surface this here for sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading the section on
arbitrary variantsit is difficult to know that there are documents forarbitrary variants, which are very relevant.arbitrary variantsare a little hidden, under a title that doesn't mention anything about CSS selectors, therefore this PR: Adds a link to the related content.I added this right after
### Arbitrary propertiesbecause it is almost as essential, and I added it before### Handling whitespacegiven that white space is a CSS selector and the order of question tends to be: