Skip to content

Added anchors to custom headings #2241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 12, 2025

Conversation

rozsazoltan
Copy link
Contributor

@rozsazoltan rozsazoltan commented May 12, 2025

Fixes: #2240

In the spirit of reusability, I declared a new component called Heading. You need to specify the level (between 1 and 6), the ID (which is mandatory), and the content of the element. With this in place, I also declared H2 through H6 elements. Thus, instead of:

<h3 id="import-directive">@import</h3>

you can use:

<H3 id="import-directive">@import</H3>

what will be:

<h3 id="import-directive">
  <a href="#import-directive" class="anchor">@import</a>
</h3>

Copy link

vercel bot commented May 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tailwindcss-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2025 2:14pm

@rozsazoltan rozsazoltan changed the title fix: added ahref to h3 by new heading component Added ahref to h3 by new heading component May 12, 2025
@rozsazoltan rozsazoltan changed the title Added ahref to h3 by new heading component Added anchors to custom headings May 12, 2025
@philipp-spiess
Copy link
Member

@rozsazoltan There's another place right now where we just add that <a> tag manually: https://github.com/tailwindlabs/tailwindcss.com/blob/main/src/docs/responsive-design.mdx?plain=1#L476-L478 I think we should just go ahead and do that instead of adding a heading component. It also seems that the anchor class isn't really necessary: https://tailwindcss.com/docs/responsive-design#using-arbitrary-container-query-values

@philipp-spiess philipp-spiess merged commit ad171bd into tailwindlabs:main May 12, 2025
2 checks passed
@rozsazoltan
Copy link
Contributor Author

Ah, indeed, that slipped my attention. Thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some <h3> elements do not contain an anchor
2 participants