Added copy button #2279
Open
Added copy button #2279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rozsazoltan
commented
Jun 16, 2025
| const result: string[] = []; | ||
| let skip = 0; | ||
|
|
||
| const commentRegex = /\/\*.*?\*\/|\/\/.*|<!--.*?-->|#.*/g; |
There was a problem hiding this comment.
I'm trying to filter out comments found in all kinds of languages as briefly as possible. Since this is client-side code that runs only occasionally, I believe it's fine to handle it with regex.
rozsazoltan
commented
Jun 16, 2025
| let skip = 0; | ||
|
|
||
| const commentRegex = /\/\*.*?\*\/|\/\/.*|<!--.*?-->|#.*/g; | ||
| const codeTagRegex = /\[!code\s+([^\]]+)\]/; |
There was a problem hiding this comment.
I also used regex to detect Shiki comments.
rozsazoltan
commented
Jun 16, 2025
| let removed = false; | ||
|
|
||
| // process comments to detect [!code ...] directives | ||
| for (const c of comments) { |
There was a problem hiding this comment.
We check every comment. If there is a Shiki match:
- we handle the
--case specially in diffs (the skip handling is necessary for this reason) - otherwise, we just remove the comment from the line
rozsazoltan
commented
Jun 16, 2025
|
|
||
| // add line if not removed and line is not empty or has no comments | ||
| if (!removed && (comments.length === 0 || line.trim() !== "")) { | ||
| result.push(line); |
There was a problem hiding this comment.
After that, we add to the result those lines that don't need to be removed (special case) and either had no comments or had comments that were removed, leaving the line empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2271
I know there are already a few active PRs (#2222, #2278), but each of them got stuck at some point for various reasons and tries to filter out Shiki comments using different logic.
Since there are multiple PRs, I'm not sure which one I should prioritize. I like the icons in the first PR, but I would also animate them using CSS. I think the second PR mainly tries to outperform the first one - unsuccessfully - and gets stuck with CSS examples or handling diffs.
There are several issues to address:
For my part, I'm currently using the code shared in this PR - it seems to be working so far:
highlight,word, and other expressions properlyI'm not convinced that this is the best solution to the problem - that's why I hesitated to share it earlier.