Add focus:outline-none to example code for focus-visible #875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See tailwindlabs/tailwindcss#4204 (Adam said that he already updated the docs, but I don't see it here. Maybe it was in another place.) When I first tried the example code, I didn't understand why the focus ring was still showing when I clicked the button with the mouse. I thought that using `focus-visible` alone would only show the ring when using the keyboard. It's only when expecting the source code that I understood that `focus:outline-none` was necessary (which on a second thought is actually quite logical).
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/tailwindlabs/tailwindcss-com/2JtVvAnWzCYMYJ2S7udigcG98fA9 |
|
Thank you this is definitely better! 👊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See tailwindlabs/tailwindcss#4204 (Adam said that he already updated the docs, but I don't see it here. Maybe it was in another place.)
When I first tried the example code, I didn't understand why the focus ring was still showing when I clicked the button with the mouse. I thought that using
focus-visiblealone would only show the ring when using the keyboard. It's only when inspecting the source code that I understood thatfocus:outline-nonewas necessary (which on a second thought makes perfect sense).