Skip to content

Shadow from modal inherited on inputs inside that modal #5042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SimonPrague opened this issue Jul 22, 2021 · 7 comments · Fixed by tailwindlabs/tailwindcss-forms#81
Closed

Comments

@SimonPrague
Copy link

SimonPrague commented Jul 22, 2021

What version of Tailwind CSS are you using?

2.2.6

What build tool (or framework if it abstracts the build tool) are you using?

vue-cli

What version of Node.js are you using?

latest

What browser are you using?

Chromium

What operating system are you using?

Fedora

Describe your issue

Everything work fine but after the latest release things got weir all over our project. We have pretty standard installation of Tailwind and CSS so I thought I should report this.

We had to go back to 2.2.4 so the problem might be already at 2.2.5

This is what's happening:

Screenshot from 2021-07-22 13-12-09

When I focus on element in modal it suddenly inherits a shadow-xl style. Which is on parent modal. It's pretty weird.

Screenshot from 2021-07-22 13-12-09 (1)

@rainerborene
Copy link

I think this is related to #5039 and recent performance changes which broke some stuff.

@adamwathan
Copy link
Member

adamwathan commented Jul 23, 2021

Hey! Any reason you deleted the reproduction field rather than providing one? That makes it extremely hard for me to be able to help.

Even just showing me the HTML for the modal and the input would help, but half of the classes on the input are cut off in the screenshot. Please help me out even a tiny bit here 🙃

@SimonPrague
Copy link
Author

SimonPrague commented Jul 23, 2021

I'm really sorry I'm not able to provide a reproduction repo. If this problem lasts longer than a week I will find the time and do this for you. Our startup is growing too fast and things are pretty intense so I apologize for not having the time to set this up. I felt that it's worth reporting even without it.

@adamwathan
Copy link
Member

@SimonPrague I understand — can you at least tell me what classes are on the input and whether or not you have the forms plugin installed?

@adamwathan
Copy link
Member

I am trying to recreate the problem not but seeing it, what am I doing differently than you?

image

@adamwathan
Copy link
Member

adamwathan commented Jul 23, 2021

Reverted the main piece of the changes that cause this stuff for v2.2.7, check that out and see if it helps. Hopefully can resolve the underlying issues and bring these improvements back soon.

Would still be super helpful to have some more information though, otherwise this is gonna be a problem for you again since I have no idea what to do to see the issue you're seeing :/

@mxlje
Copy link

mxlje commented Aug 10, 2021

Hi, I have the same problem and have reproduced it with v2.2.6 here: https://codepen.io/mxlje/pen/KKmbRGZ

Remove the shadow-xl class from the wrapper and you can see that the input no longer has a shadow when focused.

While it seems fixed in v2.2.7, the underlying issue actually comes from tailwind-forms. As you can see in the example, the input itself doesn’t have any classes applied except for the default styles that come from tailwind-forms.

The example was created with tailwind v2.2.6 and tailwind-forms v0.3.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants