Add default box shadow reset - #81
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/tailwindlabs/tailwindcss-forms/ALZxhNrELXRTnsb4jfiKFgDmvev4 |
|
We'll need to add this to the other elements that use shadows for focus rings too, like checkboxes/radios/maybe others 👍🏻 |
a00597d to
d84d728
Compare
|
@adamwathan Good catch! Updated the others as well, only added it for the "base" elements (so not for the ones with :checked or other pseudo's) |
| padding: '0', | ||
| 'font-size': 'unset', | ||
| 'line-height': 'inherit', | ||
| '--tw-shadow': '0 0 #0000', |
There was a problem hiding this comment.
Is this one needed? I can't think for sure but maybe it's not since we don't use box-shadow for any focus styles on file inputs?
There was a problem hiding this comment.
Aha, yeah I added it because I wanted to make sure that I got all the base cases, but we are indeed not adding any focus styles for this one.
However if we eventually do, probably not though, then we can't forget to add these back.
|
Looking good man thanks! I think we can simplify the box shadow calls to this now: - 'box-shadow': `var(--tw-ring-offset-shadow), var(--tw-ring-shadow), var(--tw-shadow, 0 0 #0000)`,
+ 'box-shadow': `var(--tw-ring-offset-shadow), var(--tw-ring-shadow), var(--tw-shadow)`,...since |
d84d728 to
241ac86
Compare


This PR adds a reset for the shadow to each input element, this is necessary because we are trying to get rid of the universal selector.
See: tailwindlabs/tailwindcss#5517
Fixes: tailwindlabs/tailwindcss#5042