Skip to content

Responsive border widths create wrong classes when size includes a dot #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kristiansp opened this issue Jan 12, 2019 · 2 comments · Fixed by #618
Closed

Responsive border widths create wrong classes when size includes a dot #613

kristiansp opened this issue Jan 12, 2019 · 2 comments · Fixed by #618

Comments

@kristiansp
Copy link

I seem to have come across a bug with border widths and responsive classes (possibly this also applies to other styles, but I haven't tested that).

I have a border width 0.25. Using border-b-0.25 works fine, but sm:border-b-0.25 doesn't. I discovered that it seems to generate the class .border-b-0\.sm\:25 instead of .sm\:border-b-0\.25.

If I rename the border width to 1/4 instead of 0.25, it correctly creates the class sm\:border-b-1\/4.

@kristiansp kristiansp changed the title Responsive border widths create wrong classes when size includes a diot Responsive border widths create wrong classes when size includes a dot Jan 12, 2019
@adamwathan
Copy link
Member

Thanks for this, making a note for myself that this is due to a bug in postcss-selector-parser 3.1.1, and upgrading to 5.0.0 should hopefully fix it as long as we account for breaking changes.

@kristiansp
Copy link
Author

Thanks for the prompt reply. I was wondering if the bug was somewhere else in the chain, happy you found it out. At least with another syntax it works like expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants