Skip to content

Reset all properties when using line-clamp-none #10876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RobinMalfait merged 2 commits into from
Mar 27, 2023
Merged

Reset all properties when using line-clamp-none #10876

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8bd1a44
reset other properties on `line-clamp-none`
RobinMalfait Mar 27, 2023
3377464
update CHANGELOG
RobinMalfait Mar 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Add `caption-side` utilities ([#10470](https://github.com/tailwindlabs/tailwindcss/pull/10470))
- Add `justify-normal` and `justify-stretch` utilities ([#10560](https://github.com/tailwindlabs/tailwindcss/pull/10560))
- Add `content-normal` and `content-stretch` utilities ([#10645](https://github.com/tailwindlabs/tailwindcss/pull/10645))
- Add `line-clamp` utilities from `@tailwindcss/line-clamp` to core ([#10768](https://github.com/tailwindlabs/tailwindcss/pull/10768))
- Add `line-clamp` utilities from `@tailwindcss/line-clamp` to core ([#10768](https://github.com/tailwindlabs/tailwindcss/pull/10768), [#10876](https://github.com/tailwindlabs/tailwindcss/pull/10876))
- Support ESM and TypeScript config files ([#10785](https://github.com/tailwindlabs/tailwindcss/pull/10785))
- Add `list-style-image` utilities ([#10817](https://github.com/tailwindlabs/tailwindcss/pull/10817))
- Use `:is` to make important selector option insensitive to DOM order ([#10835](https://github.com/tailwindlabs/tailwindcss/pull/10835))
Expand Down
7 changes: 6 additions & 1 deletion src/corePlugins.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,7 +717,12 @@ export let corePlugins = {
)

addUtilities({
'.line-clamp-none': { '-webkit-line-clamp': 'unset' },
'.line-clamp-none': {
overflow: 'visible',
display: 'block',
'-webkit-box-orient': 'horizontal',
'-webkit-line-clamp': 'none',
},
})
},

Expand Down
10 changes: 8 additions & 2 deletions tests/kitchen-sink.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,10 @@ crosscheck(({ stable, oxide }) => {
overflow: hidden;
}
.line-clamp-none {
-webkit-line-clamp: unset;
-webkit-line-clamp: none;
-webkit-box-orient: horizontal;
display: block;
overflow: visible;
}
.scale-50 {
--tw-scale-x: 0.5;
Expand Down Expand Up @@ -1019,7 +1022,10 @@ crosscheck(({ stable, oxide }) => {
overflow: hidden;
}
.line-clamp-none {
-webkit-line-clamp: unset;
-webkit-line-clamp: none;
-webkit-box-orient: horizontal;
display: block;
overflow: visible;
}
.scale-50 {
--tw-scale-x: 0.5;
Expand Down