Refactor parseCandidateStringsFromFiles to parseCandidateStrings
#11332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ drop the `parseCandidateStringsFromFiles` since this can be implemented using `parseCandidateStrings` already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have both
parseCandidateStringsFromFilesandparseCandidateStrings. TheparseCandidateStringscan take some options to make sure that you are running IO or the Parsing step in a sequential or parallel way.Both functions accept
ChangedContentwhich is anextensionand either the raw content or a file path. We make use of therawcontent in our tests, but this is also used when using thesafelistoption in your config.But, now that both functions exists and one can be implementation in function of the other, it is a bit nicer to remove the duplication and just support a single function.
This code doesn't exist in "production" builds right now and the code is purely internal API so there should be no breaking chnages when deleting the
parseCandidateStringsFromFilesfunction.