Ensure the oxide parser has feature parity with the stable RegEx parser #11389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests will run against the `Regex` and `Rust` based parsers. We have groups of classes of various shapes and forms + variants and rendered in various template situation (plain, html, Vue, ...) + enable all skipped tests
The classes with variants are built in the `templateTable` function, so we get them out again by using the potional arguments of the `test.each` cb function.
To make sure that we are _not_ parsing out certain values given a certain input.
The RegEx parser does extract `underline` from ```html <div class="peer-aria-[labelledby='a_b']:underline"></div> ``` ... but that's not needed and is not happening in the oxide parser This means that we have to make the output check a little bit different but they are explicit based on the feature flag.
This makes sure all the fancy SIMD stuff is as early as possible. This results in an extremely minor perf increase.
no meaningful perf difference in real world scenarios
It needs to be done in a different spot so it doesn’t affect how things are returned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that the Rust based parser now extracts all the expected candidates that the RegEx based parser also extracts.
This will allow us to eventually switch to the Rust based parser by default.
There are a few caveats:
transformerorextractoris required for a file, then the RegEx based parser will be used for that file.separatororprefixis used, then we fallback to the RegEx based parser.