[v4] Use fs.readFileSync instead of importing json file#13104
Merged
adamwathan merged 1 commit intonextfrom Mar 6, 2024
Merged
[v4] Use fs.readFileSync instead of importing json file#13104adamwathan merged 1 commit intonextfrom
fs.readFileSync instead of importing json file#13104adamwathan merged 1 commit intonextfrom
Conversation
In some environments, depending on the Node version importing a `.json` file without a `with` or `assert` doesn't work. Let's play it safe and use an `fs.readFileSync` instead.
fs.readFileSync instead of importing json filefs.readFileSync instead of importing json file
thecrypticace
approved these changes
Mar 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some environments, depending on the Node version importing a
.jsonfile without awithorassertdoesn't work.Let's play it safe and use an
fs.readFileSyncinstead.