[v4] Only allow CSS variables in @theme#13125
Merged
RobinMalfait merged 5 commits intonextfrom Mar 7, 2024
Merged
Conversation
You can `Continue` its execution (the default behaviour), `Skip` walking the current node, or `Stop` walking entirely.
There is no need to walk the `@theme` itself or to create a temporary array here.
048e678 to
37d1198
Compare
thecrypticace
approved these changes
Mar 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures that only CSS variables are allowed inside a
@themeblock.If we detect something else (apart from comments and
@keyframes), then we throw an error.