Skip to content

Conversation

@adamwathan
Copy link
Member

This PR makes utility classes use variables with fallbacks for their underlying values, rather than just using the bare value:

/* Before */
.pt-4 {
  padding-top: 1rem;
}

/* After */
.pt-4 {
  padding-top: var(--spacing-4, 1rem);
}

Not totally sold on it yet but opening as a draft as a reminder to discuss with the team next week.

@adamwathan adamwathan force-pushed the use-variables-for-utilities branch from 6835ef8 to b2586d4 Compare March 11, 2024 19:23
@RobinMalfait RobinMalfait force-pushed the use-variables-for-utilities branch from b2586d4 to 4bc23ca Compare March 21, 2024 16:58
@RobinMalfait RobinMalfait marked this pull request as ready for review March 21, 2024 17:12
@RobinMalfait RobinMalfait merged commit b5df5e9 into next Mar 21, 2024
@RobinMalfait RobinMalfait deleted the use-variables-for-utilities branch March 21, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants