Skip to content

Fix incorrect properties in line-clamp utilities#13220

Merged
RobinMalfait merged 4 commits intotailwindlabs:nextfrom
hmbanan666:fix/issue-13217
Mar 12, 2024
Merged

Fix incorrect properties in line-clamp utilities#13220
RobinMalfait merged 4 commits intotailwindlabs:nextfrom
hmbanan666:fix/issue-13217

Conversation

@hmbanan666
Copy link
Contributor

@hmbanan666 hmbanan666 commented Mar 12, 2024

Hi! I found bug and fixed it.

Fixes: #13217

@hmbanan666
Copy link
Contributor Author

Opened issue before: #13217

@adamwathan
Copy link
Member

This is the most embarrassing thing that has ever been discovered in the Tailwind CSS codebase. Will get this merged and get a release out soon, thank you 😆

@hmbanan666
Copy link
Contributor Author

Also find here problem with -webkit-box-orient which suppose to be horizontal (not horizonal).
And -webkit-line-clamp: it can't be "none"

@hmbanan666
Copy link
Contributor Author

Ok, tests showed:

- Expected
+ Received

  ".line-clamp-4 {
-   overflow: hidden;
    -webkit-line-clamp: 4;
    -webkit-box-orient: vertical;
    display: -webkit-box;
+   overflow: hidden;
  }

  .line-clamp-99 {
-   overflow: hidden;
    -webkit-line-clamp: 99;
    -webkit-box-orient: vertical;
    display: -webkit-box;
+   overflow: hidden;
  }

  .line-clamp-\[123\] {
-   overflow: hidden;
    -webkit-line-clamp: 123;
    -webkit-box-orient: vertical;
    display: -webkit-box;
+   overflow: hidden;
  }

  .line-clamp-none {
-   overflow: visible;
-   -webkit-box-orient: horizontal;
    -webkit-line-clamp: unset;
+   -webkit-box-orient: horizontal;
    display: block;
+   overflow: visible;
  }"

Pushed one more commit to fix this test 🙏

@RobinMalfait RobinMalfait changed the title Overflow fixed Fix line-clamp utilities Mar 12, 2024
@RobinMalfait RobinMalfait changed the title Fix line-clamp utilities Fix incorrect properties in line-clamp utilities Mar 12, 2024
@RobinMalfait RobinMalfait merged commit 7452425 into tailwindlabs:next Mar 12, 2024
@hmbanan666 hmbanan666 deleted the fix/issue-13217 branch March 13, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants