Speed up segmentation #13415
Merged
Speed up segmentation #13415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
#13393 also defines some char code constants - these should probably be moved out to a common file |
thecrypticace
approved these changes
Apr 2, 2024
RobinMalfait
approved these changes
Apr 2, 2024
Contributor
|
Thanks! 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saw this tweet and wanted to pitch in. This speeds up the
segmentfunction from ~1.2x to ~1.5x, at the cost of some readability.Benchmark is below. Could use some larger or smaller test cases!
