Print eventual lightning CSS parsing errors when the CSS matcher fail #14034
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on adding a test case with the slightly more complex arbitrary variants names:
we noticed that the CSS formatting helpers were giving us unhelpful diff outputs that would make it hard to find the issue.
It turns out that we try to normalize the CSS with lightningcss and automatically fall back to prettier if lightning fails. This caused confusion and quite a bit of time to understand what's going on. In our case, the CSS being generated by Tailwind was not adding quotes around attribute selectors which caused lightning to fail but prettier to automatically insert these quotes.
To fix this, we now capture any eventual lightning error and include it when the test matcher is going to fail (so we keep the tests that currently rely on this behavior clean while adding useful debug information for new tests).
Here's an example of the new error message: