Skip to content

Remove cursor override for :disabled buttons #14061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 29, 2024

Conversation

kachkaev
Copy link
Contributor

@kachkaev kachkaev commented Jul 25, 2024

Related to #8961 and #8962

Before v4, buttons got this CSS in preflight:

/*
Set the default cursor for buttons.
*/
button,
[role="button"] {
cursor: pointer;
}
/*
Make sure disabled buttons don't get the pointer cursor.
*/
:disabled {
cursor: default;
}

v4 (next branch) no longer has cursor: pointer in preflight.css

This PR removes additional CSS for :disabled buttons. It was meant to undo an override that is no longer present.

@kachkaev
Copy link
Contributor Author

kachkaev commented Jul 26, 2024

I’m trying to runpnpm build && pnpm test locally to update snapshots, but am getting this:

@tailwindcss/oxide:build: cache miss, executing d9f5bb4236319147
@tailwindcss/oxide:build: 
@tailwindcss/oxide:build: > @tailwindcss/oxide@4.0.0-alpha.18 build /private/tmp/tailwindcss/crates/node
@tailwindcss/oxide:build: > npx napi build --platform --release --no-const-enum
@tailwindcss/oxide:build: 
   Compiling memchr v2.5.0
@tailwindcss/oxide:build:    Compiling proc-macro2 v1.0.59
@tailwindcss/oxide:build:    Compiling quote v1.0.28
@tailwindcss/oxide:build:    Compiling crossbeam-utils v0.8.15
@tailwindcss/oxide:build:    Compiling log v0.4.18
@tailwindcss/oxide:build:    Compiling memoffset v0.8.0
@tailwindcss/oxide:build:    Compiling crossbeam-epoch v0.9.14
@tailwindcss/oxide:build:    Compiling libc v0.2.144
@tailwindcss/oxide:build:    Compiling semver v1.0.17
@tailwindcss/oxide:build:    Compiling crossbeam-queue v0.3.8
@tailwindcss/oxide:build:     Building [==>                        ] 13/97: memchr(build.rs), crossbeam-queue(build.rs), proc-macro2(build.rs), crossbeam-utils(build.rs), semver(build.rs), libc(build.rs), crossbeam-epoch(build.rs), quo@tailwindcss/oxide:build: error: linking with `cc` failed: exit status: 1
@tailwindcss/oxide:build:   |
@tailwindcss/oxide:build:   = note: "cc" "-arch" "arm64" "/var/folders/4d/7r67shjj3j98lrjcwktwqcfr0000gn/T/rustcYAfcFY/symbols.o" "/private/tmp/tailwindcss/target/release/build/semver-937ca7566b75a901/build_script_build-937ca7566b75a901.build_script_build.1f934ee8-cgu.0.rcgu.o" "/private/tmp/tailwindcss/target/release/build/semver-937ca7566b75a901/build_script_build-937ca7566b75a901.build_script_build.1f934ee8-cgu.1.rcgu.o" "/private/tmp/tailwindcss/target/release/build/semver-937ca7566b75a901/build_script_build-937ca7566b75a901.build_script_build.1f934ee8-cgu.10.rcgu.o" "/private/tmp/tailwindcss/target/release/build/semver-937ca7566b75a901/build_script_build-937ca7566b75a901.build_script_build.1f934ee8-cgu.11.rcgu.o" "/private/tmp/tailwindcss/target/release/build/semver-937ca7566b75a901/build_script_build-937ca7566b75a901.build_script_build.1f934ee8-cgu.12.rcgu.o" "/private/tmp/tailwindcss/target/release/build/semver-937ca7566b75a901/build_script_build-937ca7566b75a901.build_script_build.1f934ee8-cgu.13.rcgu.o" "/private/tmp/tailwindcss/target/release/build/semver-937ca7566b75a901/build_script_build-937ca7566b75a901.build_script_build.1f934ee8-cgu.14.rcgu.o" "/private/tmp/tailwindcss/target/release/build/semver-937ca7566b75a901/build_script_build-937ca7566b75a901.build_script_build.1f934ee8-cgu.15.rcgu.o" "/private/tmp/tailwindcss/target/release/build/semver-937ca7566b75a901/build_script_build-937ca7566b75a901.build_script_build.1f934ee8-cgu.2.rcgu.o" "/private/tmp/tailwindcss/target/release/build/semver-937ca7566b75a901/build_script_build-937ca7566b75a901.build_script_build.1f934ee8-cgu.3.rcgu.o" "/private/tmp/tailwindcss/target/release/build/semver-937ca7566b75a901/build_script_build-937ca7566b75a901.build_script_build.1f934ee8-cgu.4.rcgu.o" "/private/tmp/tailwindcss/target/release/build/semver-937ca7566b75a901/build_script_build-937ca7566b75a901.build_script_build.1f934ee8-cgu.5.rcgu.o" "/private/tmp/tailwindcss/target/release/build/semver-937ca7566b75a901/build_script_build-937ca7566b75a901.build_script_build.1f934ee8-cgu.6.rcgu.o" "/private/tmp/tailwindcss/target/release/build/semver-937ca7566b75a901/build_script_build-937ca7566b75a901.build_script_build.1f934ee8-cgu.7.rcgu.o" "/private/tmp/tailwindcss/target/release/build/semver-937ca7566b75a901/build_script_build-937ca7566b75a901.build_script_build.1f934ee8-cgu.8.rcgu.o" "/private/tmp/tailwindcss/target/release/build/semver-937ca7566b75a901/build_script_build-937ca7566b75a901.build_script_build.1f934ee8-cgu.9.rcgu.o" "/private/tmp/tailwindcss/target/release/build/semver-937ca7566b75a901/build_script_build-937ca7566b75a901.4jbodhls8jryi76.rcgu.o" "-L" "/private/tmp/tailwindcss/target/release/deps" "-L" "/Users/me/.rustup/toolchains/stable-aarch64-apple-darwin/lib/rustlib/aarch64-apple-darwin/lib" "/Users/me/.rustup/toolchains/stable-aarch64-apple-darwin/lib/rustlib/aarch64-apple-darwin/lib/libstd-e24e0c7fd09714c0.rlib" "/Users/me/.rustup/toolchains/stable-aarch64-apple-darwin/lib/rustlib/aarch64-apple-darwin/lib/libpanic_unwind-b21ee2fb93f4a334.rlib" "/Users/me/.rustup/toolchains/stable-aarch64-apple-darwin/lib/rustlib/aarch64-apple-darwin/lib/libobject-4ce05f7a889fff94.rlib" "/Users/me/.rustup/toolchains/stable-aarch64-apple-darwin/lib/rustlib/aarch64-apple-darwin/lib/libmemchr-066d562bc324b771.rlib" "/Users/me/.rustup/toolchains/stable-aarch64-apple-darwin/lib/rustlib/aarch64-apple-darwin/lib/libaddr2line-8cb0c59b12697637.rlib" "/Users/me/.rustup/toolchains/stable-aarch64-apple-darwin/lib/rustlib/aarch64-apple-darwin/lib/libgimli-07d89e6b9536e071.rlib" "/Users/me/.rustup/toolchains/stable-aarch64-apple-darwin/lib/rustlib/aarch64-apple-darwin/lib/librustc_demangle-c65b90a0ba43b683.rlib" "/Users/me/.rustup/toolchains/stable-aarch64-apple-darwin/lib/rustlib/aarch64-apple-darwin/lib/libstd_detect-9f8f7348c047b33a.rlib" "/Users/me/.rustup/toolchains/stable-aarch64-apple-darwin/lib/rustlib/aarch64-apple-darwin/lib/libhashbrown-34c451524b66e414.rlib" "/Users/me/.rustup/toolchains/stable-aarch64-apple-darwin/lib/rustlib/aarch64-apple-darwin/lib/libminiz_oxide-b1a98f39eda4ff6a.rlib" "/Users/me/.rustup/toolchains/stable-aarch64-apple-darwin/lib/rustlib/aarch64-apple-darwin/lib/libadler-1c7622591b95f47e.rlib" "/Users/me/.rustup/toolchains/stable-aarch64-apple-darwin/lib/rustlib/aarch64-apple-darwin/lib/librustc_std_workspace_alloc-5ee0c1cf171b84b0.rlib" "/Users/me/.rustup/toolchains/stable-aarch64-apple-darwin/lib/rustlib/aarch64-apple-darwin/lib/libunwind-3ee364d970255739.rlib" "/Users/me/.rustup/toolchains/stable-aarch64-apple-darwin/lib/rustlib/aarch64-apple-darwin/lib/libcfg_if-85b53c7fb22d1018.rlib" "/Users/me/.rustup/toolchains/stable-aarch64-apple-darwin/lib/rustlib/aarch64-apple-darwin/lib/liblibc-b5372de70a998108.rlib" "/Users/me/.rustup/toolchains/stable-aarch64-apple-darwin/lib/rustlib/aarch64-apple-darwin/lib/liballoc-945b7af0c9f21aac.rlib" "/Users/me/.rustup/toolchains/stable-aarch64-apple-darwin/lib/rustlib/aarch64-apple-darwin/lib/librustc_std_workspace_core-0251f0b5857602a2.rlib" "/Users/me/.rustup/toolchains/stable-aarch64-apple-darwin/lib/rustlib/aarch64-apple-darwin/lib/libcore-9382e8c089006a25.rlib" "/Users/me/.rustup/toolchains/stable-aarch64-apple-darwin/lib/rustlib/aarch64-apple-darwin/lib/libcompiler_builtins-6b5d600bff28faab.rlib" "-lSystem" "-lresolv" "-lc" "-lm" "-liconv" "-L" "/Users/me/.rustup/toolchains/stable-aarch64-apple-darwin/lib/rustlib/aarch64-apple-darwin/lib" "-o" "/private/tmp/tailwindcss/target/release/build/semver-937ca7566b75a901/build_script_build-937ca7566b75a901" "-Wl,-dead_strip" "-nodefaultlibs"
@tailwindcss/oxide:build:   = note: clang: error: unable to execute command: Segmentation fault: 11
@tailwindcss/oxide:build:           clang: error: linker command failed due to signal (use -v to see invocation)
@tailwindcss/oxide:build:           
@tailwindcss/oxide:build: 
@tailwindcss/oxide:build:     Building [==>                        ] 13/97: memchr(build.rs), crossbeam-queue(build.rs), proc-macro2(build.rs), crossbeam-utils(build.rs), semver(build.rs), libc(build.rs), crossbeam-epoch(build.rs), quo@tailwindcss/oxide:build: error: could not compile `semver` due to previous error
@tailwindcss/oxide:build: warning: build failed, waiting for other jobs to finish...
@tailwindcss/oxide:build:     Building [==>                        ] 14/97: memchr(build.rs), crossbeam-queue(build.rs), proc-macro2(build.rs), crossbeam-utils(build.rs), libc(build.rs), crossbeam-epoch(build.rs), quote(build.rs), memo@tailwindcss/oxide:build: error: linking with `cc` failed: exit status: 1
@tailwindcss/oxide:build:   |
@tailwindcss/oxide:build:   = note: "cc" "-arch" "arm64" "/var/folders/4d/7r67shjj3j98lrjcwktwqcfr0000gn/T/rustcSqnACX/symbols.o" "/private/tmp/tailwindcss/target/release/build/proc-macro2-2c7b011f61bc4a68/build_script_build-2c7b011f61bc4a68.build_script_build.35343e50-cgu.0.rcgu.o" "/private/tmp/tailwindcss/target/release/build/proc-macro2-2c7b011f61bc4a68/build_script_build-2c7b011f61bc4a68.build_script_build.35343e50-cgu.1.rcgu.o" "/private/tmp/tailwindcss/target/release/build/proc-macro2-2c7b011f61bc4a68/build_script_build-2c7b011f61bc4a68.build_script_build.35343e50-cgu.10.rcgu.o" "/private/tmp/tailwindcss/target/release/build/proc-macro2-2c7b011f61bc4a68/build_script_build-2c7b011f61bc4a68.build_script_build.35343e50-cgu.11.rcgu.o" "/private/tmp/tailwindcss/target/release/build/proc-macro2-2c7b011f61bc4a68/build_script_build-2c7b011f61bc4a68.build_script_build.35343e50-cgu.12.rcgu.o" "/private/tmp/tailwindcss/target/release/build/proc-macro2-2c7b011f61bc4a68/build_script_build-2c7b011f61bc4a68.build_script_build.35343e50-cgu.13.rcgu.o" "/private/tmp/tailwindcss/target/release/build/proc-macro2-2c7b011f61bc4a68/build_script_build-2c7b011f61bc4a68.build_script_build.35343e50-cgu.14.rcgu.o" "/private/tmp/tailwindcss/target/release/build/proc-macro2-2c7b011f61bc4a68/build_script_build-2c7b011f61bc4a68.build_script_build.35343e50-cgu.15.rcgu.o" "/private/tmp/tailwindcss/target/release/build/proc-macro2-2c7b011f61bc4a68/build_script_build-2c7b011f61bc4a68.build_script_build.35343e50-cgu.2.rcgu.o" "/private/tmp/tailwindcss/target/release/build/proc-macro2-2c7b011f61bc4a68/build_script_build-2c7b011f61bc4a68.build_script_build.35343e50-cgu.3.rcgu.o" "/private/tmp/tailwindcss/target/release/build/proc-macro2-2c7b011f61bc4a68/build_script_build-2c7b011f61bc4a68.build_script_build.35343e50-cgu.4.rcgu.o" "/private/tmp/tailwindcss/target/release/build/proc-macro2-2c7b011f61bc4a68/build_script_build-2c7b011f61bc4a68.build_script
...

Using MBP on M1. Will try again this weekend.


UPD: I managed to update the snapshot by doing some random hacking (5d2d18e). I could not fix Segmentation fault errors in the Rust builds. Hope it’s something with my local setup and that other contributors are not affected.

@adamwathan
Copy link
Member

Good catch, thanks!

@adamwathan adamwathan merged commit 87c9f32 into tailwindlabs:next Jul 29, 2024
1 check passed
@kachkaev kachkaev deleted the patch-1 branch July 29, 2024 14:13
@JoshuaS98
Copy link

But what I don't get is that the button rule was silently removed going to v4 and no where is spoken about it? preflight.css was moved to another folder and without mention deleted this?

button,
[role="button"] {
  cursor: pointer;
}

tongrow pushed a commit to tongrow/tailwind-normalize that referenced this pull request Jun 2, 2025
Related to tailwindlabs#8961 and
tailwindlabs#8962

Before v4, buttons got this CSS in preflight:

https://github.com/tailwindlabs/tailwindcss/blob/9824cb64a03afaa405e184cb31003c8a1efafaa7/src/css/preflight.css#L339-L353

v4 (`next` branch) no longer has `cursor: pointer` in
[preflight.css](https://github.com/tailwindlabs/tailwindcss/blob/2fe249963583e436961adc59cf9988af454e3da5/packages/tailwindcss/preflight.css)

This PR removes additional CSS for `:disabled` buttons. It was meant to
undo an override that is no longer present.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants