-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Remove cursor override for :disabled
buttons
#14061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I’m trying to run
Using MBP on M1. Will try again this weekend. UPD: I managed to update the snapshot by doing some random hacking (5d2d18e). I could not fix |
…pnpm test -- -u`" This reverts commit 5d2d18e.
Good catch, thanks! |
But what I don't get is that the button rule was silently removed going to v4 and no where is spoken about it?
|
Related to tailwindlabs#8961 and tailwindlabs#8962 Before v4, buttons got this CSS in preflight: https://github.com/tailwindlabs/tailwindcss/blob/9824cb64a03afaa405e184cb31003c8a1efafaa7/src/css/preflight.css#L339-L353 v4 (`next` branch) no longer has `cursor: pointer` in [preflight.css](https://github.com/tailwindlabs/tailwindcss/blob/2fe249963583e436961adc59cf9988af454e3da5/packages/tailwindcss/preflight.css) This PR removes additional CSS for `:disabled` buttons. It was meant to undo an override that is no longer present.
Related to #8961 and #8962
Before v4, buttons got this CSS in preflight:
tailwindcss/src/css/preflight.css
Lines 339 to 353 in 9824cb6
v4 (
next
branch) no longer hascursor: pointer
in preflight.cssThis PR removes additional CSS for
:disabled
buttons. It was meant to undo an override that is no longer present.