Bump dependencies - #14160
Merged
Merged
Conversation
This wasn't applied everywhere yet.
+ apply necessary changes in the `turbo.json` file
This splits the rendering on a per-task basis. But the best part is that at the end the output is grouped per task instead of mixed with output from different steps.
philipp-spiess
approved these changes
Aug 9, 2024
| { | ||
| "$schema": "https://turbo.build/schema.json", | ||
| "pipeline": { | ||
| "ui": "tui", |
Contributor
There was a problem hiding this comment.
this will require some getting used to hah
philipp-spiess
added a commit
that referenced
this pull request
Aug 12, 2024
While rebasing on the latest changes on `next`, especially #14160, I noticed that my local `pnpm build` step was no longer working and erring with the following: ``` │ > @tailwindcss/oxide@4.0.0-alpha.19 build /Users/philipp/dev/tailwindcss/crates/node │ > npx napi build --platform --release --no-const-enum │ │ Type Error: Could not parse the Cargo.toml: Error: Command failed: cargo metadata --format-version 1 --manifest-path "/Users/philipp/dev/ │ tailwindcss/crates/node/Cargo.toml" │ error: rustup could not choose a version of cargo to run, because one wasn't specified explicitly, and no default is configured. │ help: run 'rustup default stable' to download the latest stable release of Rust and set it as your default toolchain. │ │ error: rustup could not choose a version of cargo to run, because one wasn't specified explicitly, and no default is configured. │ help: run 'rustup default stable' to download the latest stable release of Rust and set it as your default toolchain. ``` It turns out that with the changes in turbo v2, env variables no longer propagate to the individual tasks automatically but since I installed rustup outside of the default `~/.rustup` directory, the task was no longer able to find it. To fix this, we now define `RUSTUP_HOME` as a global env to always pass through.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR bumps dependencies
We also make some dependencies
catalog:dependencies, which allows us to keepthe version in sync. E.g.:
lightningcssand@types/node.Bumped
turboto the latest version + enabled the new UIFixed a bug in the tests now that
lightningcssoutputs the correct value.