Properly resolve theme('someKey.DEFAULT') when only --some-key-* keys exist - #14354
Merged
Merged
Conversation
RobinMalfait
force-pushed
the
fix/default-theme-values-resolving-to-objects
branch
from
September 5, 2024 22:11
f4e6bef to
9174b09
Compare
adamwathan
force-pushed
the
fix/default-theme-values-resolving-to-objects
branch
from
September 6, 2024 03:55
9174b09 to
91e9d29
Compare
philipp-spiess
approved these changes
Sep 6, 2024
RobinMalfait
force-pushed
the
fix/default-theme-values-resolving-to-objects
branch
from
September 6, 2024 11:00
91e9d29 to
9a8d3c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where theme function calls like
theme('transitionTimingFunction.DEFAULT')would incorrectly resolve to an object when the set of defined CSS theme values looked like this:We were mistakenly retrieving the entire
--transition-timing-function-*namespace in this case and returning an object, even though the user is explicitly asking for a single value by including.DEFAULTin their call.This ensures it resolves to null instead. Fixes an issue I ran into on this live stream earlier today:
https://x.com/adamwathan/status/1831740214051799281