Add codemod for migrating the @screen directive
#14749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @RobinMalfait and the rest of your teammates on |
329126b to
14e1cac
Compare
75fac72 to
558fa90
Compare
philipp-spiess
approved these changes
Oct 22, 2024
Comment on lines
+27
to
+31
| // First migrate `@screen md` to `@media screen(md)` | ||
| root.walkAtRules('screen', (node) => { | ||
| node.name = 'media' | ||
| node.params = `screen(${node.params})` | ||
| }) |
f677933 to
a2d0425
Compare
e86e03d to
bd63fb2
Compare
Member
Merge activity
|
This PR adds a codemod for migrating the old `@screen` directive from Tailwind CSS v2 that also worked in Tailwind CSS v3 but wasn't documented anymore. Internally, this first migrates `@screen md` to `@media screen(md)`, then we rely on the existing migration that migrates the `screen(…)` function. Input: ```css @screen md { .foo { color: red; } } ``` Output (IR): ```css @media screen(md) { .foo { color: red; } } ``` Output: ```css @media theme(--breakpoint-md) { .foo { color: red; } } ```
13a8a63 to
5bf2efb
Compare
bd63fb2 to
02cb52a
Compare
Base automatically changed from
robin/feat/migrate-variants-and-responsive-directives
to
next
October 22, 2024 16:15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a codemod for migrating the old
@screendirective from TailwindCSS v2 that also worked in Tailwind CSS v3 but wasn't documented anymore.
Internally, this first migrates
@screen mdto@media screen(md), then we rely on the existing migration that migrates thescreen(…)function.Input:
Output (IR):
Output: